Skip to content

fix(ci): remove deprecated --no-update flag from poetry lock#1074

Merged
openshift-merge-bot[bot] merged 1 commit into
project-codeflare:mainfrom
kryanbeane:fix/poetry-lock-v2-compat
May 6, 2026
Merged

fix(ci): remove deprecated --no-update flag from poetry lock#1074
openshift-merge-bot[bot] merged 1 commit into
project-codeflare:mainfrom
kryanbeane:fix/poetry-lock-v2-compat

Conversation

@kryanbeane

@kryanbeane kryanbeane commented May 6, 2026

Copy link
Copy Markdown
Contributor

Summary

The update-versions workflow fails at the "Regenerate poetry.lock" step because poetry lock --no-update is not a valid option in Poetry 2.x. The GitHub Actions runner installs the latest Poetry (now 2.x), which removed this flag.

In Poetry 2.x, poetry lock (without flags) already preserves existing locked versions by default — matching the old --no-update semantics from 1.x.

Changes

  • Remove --no-update flag from poetry lock in the update-versions workflow

Poetry 2.x removed the --no-update option. The default behavior of
`poetry lock` in v2 already preserves existing locked versions unless
constraints have changed, matching the old --no-update semantics.

Signed-off-by: kryanbeane <bryankeane0@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci openshift-ci Bot requested review from pawelpaszki and szaher May 6, 2026 10:38
@codecov

codecov Bot commented May 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.56%. Comparing base (1928fdc) to head (58a3146).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1074   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files          23       23           
  Lines        2272     2272           
=======================================
  Hits         2194     2194           
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2026
@openshift-ci

openshift-ci Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pawelpaszki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit f6f2593 into project-codeflare:main May 6, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants